Fix #1035 - Add Interfaces to Configuration objects #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
added
area:client
mcruzdev
reviewed
Apr 3, 2025
Member
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
Do you believe that I started something related for server extension today? I left a comment @ricardozanini!
| * Sample</a> | ||
| */ | ||
| @ConfigItem(name = ConfigItem.PARENT) | ||
| public Map<String, String> authConfigParams; |
Member
There was a problem hiding this comment.
Is @WithParentName not necessary here?
Member
Author
There was a problem hiding this comment.
Why? This implementation was lazy then, leaving it as a can-be-anything string. Now we have settled the properties in the API so that the birds can chirp again.
Member
Author
There was a problem hiding this comment.
Oh you mean in username? No, we don't need it. The IDE with Quarkus plugin installed now recognizes these properties beautifully.
fjtirado
approved these changes
Apr 4, 2025
Member
Author
|
@hbelmiro any thoughts? |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
Signed-off-by: Ricardo Zanini <[email protected]>
7 tasks
hbelmiro
pushed a commit
that referenced
this pull request
Apr 5, 2025
Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fix #1035
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.